Skip to content

Conversation

@Ugonnaak1
Copy link
Contributor

Copy link
Contributor

@chlowell chlowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be no test changes. Deprecated API is still useable.

@rayluo
Copy link
Contributor

rayluo commented Sep 26, 2025

FYI: I reviewed its counterpart in MSAL Python repo. Some of the points there are also applicable here. Namely, (1) shall this PR deprecate ROPC for PCA only? (2) existing test cases shall not be removed.

@sonarqubecloud
Copy link

@Ugonnaak1 Ugonnaak1 requested a review from chlowell September 29, 2025 16:00
@Ugonnaak1 Ugonnaak1 merged commit e59524a into main Sep 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants